Re: overlapping strncpy/memcpy errors via valgrind

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: overlapping strncpy/memcpy errors via valgrind
Дата
Msg-id 12103.1361118400@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: overlapping strncpy/memcpy errors via valgrind  (Boszormenyi Zoltan <zb@cybertec.at>)
Ответы Re: overlapping strncpy/memcpy errors via valgrind  (Greg Stark <stark@mit.edu>)
Re: overlapping strncpy/memcpy errors via valgrind  ("anarazel@anarazel.de" <andres@anarazel.de>)
Список pgsql-hackers
Boszormenyi Zoltan <zb@cybertec.at> writes:
> Then, why isn't memcpy() skipped if the source and dest are the same?
> It would be a micro-optimization but a valid one.

No, it'd be more like a micro-pessimization, because the test would be
wasted effort in the vast majority of calls.  The *only* reason to do
this would be to shut up valgrind, and that seems annoying.

I wonder if anyone's tried filing a bug against valgrind to say that it
shouldn't complain about this case.
        regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Boszormenyi Zoltan
Дата:
Сообщение: Re: overlapping strncpy/memcpy errors via valgrind
Следующее
От: Tom Lane
Дата:
Сообщение: Re: FDW for PostgreSQL