Re: remove unneeded pstrdup in fetch_table_list

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: remove unneeded pstrdup in fetch_table_list
Дата
Msg-id 1370092.1610601662@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: remove unneeded pstrdup in fetch_table_list  (Michael Paquier <michael@paquier.xyz>)
Ответы Re: remove unneeded pstrdup in fetch_table_list  (Amit Kapila <amit.kapila16@gmail.com>)
Список pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> On Thu, Jan 14, 2021 at 01:17:57AM +0000, Hou, Zhijie wrote:
>>>> Thanks. I am thinking to backpatch this even though there is no
>>>> problem reported from any production system. What do you think?

> text_to_cstring() indeed allocates a new string, so the extra
> allocation is useless.  FWIW, I don't see much point in poking at
> the stable branches here.

Yeah, unless there's some reason to think that this creates a
meaningful memory leak, I wouldn't bother back-patching.

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: remove unneeded pstrdup in fetch_table_list
Следующее
От: Peter Smith
Дата:
Сообщение: Re: Single transaction in the tablesync worker?