Re: pg_dump vs malloc

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: pg_dump vs malloc
Дата
Msg-id 1401.1308757736@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: pg_dump vs malloc  (Magnus Hagander <magnus@hagander.net>)
Ответы Re: pg_dump vs malloc  (Magnus Hagander <magnus@hagander.net>)
Список pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes:
> Something along the line of this?

I think this is a seriously, seriously bad idea:

> +#define strdup(x) pg_strdup(x)
> +#define malloc(x) pg_malloc(x)
> +#define calloc(x,y) pg_calloc(x, y)
> +#define realloc(x,y) pg_realloc(x, y)

as it will render the code unreadable to people expecting the normal
behavior of these fundamental functions; not to mention break any
call sites that have some other means of dealing with an alloc failure
besides going belly-up.  Please take the trouble to do
s/malloc/pg_malloc/g and so on, instead.
        regards, tom lane


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: smallserial / serial2
Следующее
От: Peter Geoghegan
Дата:
Сообщение: Re: pg_dump vs malloc