Re: Question: Why Are File Descriptors Not Closed and Accounted for PostgreSQL Backends?

Поиск
Список
Период
Сортировка
От Srinath Reddy Sadipiralla
Тема Re: Question: Why Are File Descriptors Not Closed and Accounted for PostgreSQL Backends?
Дата
Msg-id 18faaebda89.391037fa8052.3452722946693562480@zohocorp.com
обсуждение исходный текст
Ответ на Re: Question: Why Are File Descriptors Not Closed and Accounted for PostgreSQL Backends?  (Heikki Linnakangas <hlinnaka@iki.fi>)
Список pgsql-hackers
Дерево обсуждения
Thanks for the reply,yeah i know about FreeWaitEventSet() but that is being used in few places but not for handling backends.

i got it that FDs like FeBeWaitSet->epoll_fd will be free'd when connection is terminated but as i mentioned wouldn't it be an issue if the connection is long living lets take idle which can be running queries for long time,what if we have multiple connections like this running queries using multiple system FDs and reach the limit,cause they are using FDs ,so they may not be free'd.



---- On Fri, 24 May 2024 19:15:54 +0530 Heikki Linnakangas <hlinnaka@iki.fi> wrote ---

On 24/05/2024 15:17, Srinath Reddy Sadipiralla wrote:
> Hi PostgreSQL Community,
> when a backend process starts, pq_init is called where it opens a FD during CreateWaitEventSet()
>
>
> if (!AcquireExternalFD())
> {
> /* treat this as though epoll_create1 itself returned EMFILE */
> elog(ERROR, "epoll_create1 failed: %m");
> }
> set->epoll_fd = epoll_create1(EPOLL_CLOEXEC);
>
>
> but we didn't closed or called ReleaseExternalFD() for accounting

Yes we do, see FreeWaitEventSet().

The WaitEventSet created fro pq_init() is never explicitly free'd
though, because it's created in the per-connection backend process. When
the connection is terminated, the backend process exits, cleaning up any
resources including the WaitEventSet.

--
Heikki Linnakangas
Neon (https://neon.tech)





В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: PG catalog
Следующее
От: Peter Eisentraut
Дата:
Сообщение: Re: Upgrade Debian CI images to Bookworm