Re: Variable renaming in AllocSetContextCreate (will commit soon, no functional impact)

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Variable renaming in AllocSetContextCreate (will commit soon, no functional impact)
Дата
Msg-id 1944.1424581637@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Variable renaming in AllocSetContextCreate (will commit soon, no functional impact)  (Jeff Davis <pgsql@j-davis.com>)
Ответы Re: Variable renaming in AllocSetContextCreate (will commit soon, no functional impact)  (Jeff Davis <pgsql@j-davis.com>)
Список pgsql-hackers
Jeff Davis <pgsql@j-davis.com> writes:
> This is just to make the variable names in this function consistent with
> the rest of the file (and less confusing). No functional impact, so I'll
> commit soon unless someone objects.

If I'm reading this right, this creates two different variables pointing
at the same object.  That does not sound like an improvement from a
readability standpoint.

If you want to have just *one* variable but change its name and type,
I'd be ok with that.
        regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Petr Jelinek
Дата:
Сообщение: Re: Redesigning checkpoint_segments
Следующее
От: Jeff Davis
Дата:
Сообщение: Re: PATCH: decreasing memory needlessly consumed by array_agg