Re: compiling with ssl without thread safety still broken

Поиск
Список
Период
Сортировка
От Bruce Momjian
Тема Re: compiling with ssl without thread safety still broken
Дата
Msg-id 200403271934.i2RJY7327164@candle.pha.pa.us
обсуждение исходный текст
Ответ на Re: compiling with ssl without thread safety still broken  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-patches
Tom Lane wrote:
> Kris Jurka <books@ejurka.com> writes:
> > Compiling with ssl without thread safety still broken.
> > pq_initssllib is being incorrectly guarded by ENABLE_THREAD_SAFETY.
>
> Not to mention that it has NO business being declared at some random
> place in the middle of the file.  Fix committed, but some further review
> of this mare's-nest seems warranted.

Yuck, I should have looked over this patch more closely.

> This file is getting to be a poster child for the reasons not to use
> #ifdefs :-(

Agreed.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

В списке pgsql-patches по дате отправления:

Предыдущее
От: Bruce Momjian
Дата:
Сообщение: Re: APC/socket fix (final?)
Следующее
От: "Magnus Hagander"
Дата:
Сообщение: Re: Updated logging config (was: Initial eventlog support on win32 )