Re: Error in recent pg_dump change (coverity)

Поиск
Список
Период
Сортировка
От Martijn van Oosterhout
Тема Re: Error in recent pg_dump change (coverity)
Дата
Msg-id 20060528160111.GB22869@svana.org
обсуждение исходный текст
Ответ на Re: Error in recent pg_dump change (coverity)  (Alvaro Herrera <alvherre@commandprompt.com>)
Список pgsql-hackers
On Sun, May 28, 2006 at 11:42:48AM -0400, Alvaro Herrera wrote:
> Martijn van Oosterhout wrote:
> > I'd actually suggest zeroing out res->tuples in PQclear so this sort of
> > problem becomes much more obvious.
>
> Is it worthwhile to zero out the res->block array as well?

Patch is good, but setting block to NULL is a waste of time, it's not
global. And I think res->curBlock is automatically set NULL as result
of the loop...

Have a nice day,
--
Martijn van Oosterhout   <kleptog@svana.org>   http://svana.org/kleptog/
> From each according to his ability. To each according to his ability to litigate.

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: Error in recent pg_dump change (coverity)
Следующее
От: Martijn van Oosterhout
Дата:
Сообщение: Re: Error in recent pg_dump change (coverity)