Re: Improve shutdown during online backup, take 4

Поиск
Список
Период
Сортировка
От Magnus Hagander
Тема Re: Improve shutdown during online backup, take 4
Дата
Msg-id 20080423104323.04948d8f@mha-laptop
обсуждение исходный текст
Ответ на Improve shutdown during online backup, take 2  ("Albe Laurenz" <laurenz.albe@wien.gv.at>)
Список pgsql-patches
Albe Laurenz wrote:
> Magnus Hagander wrote:
> > This doesn't look like our normal coding standards, and should
> > probably be changed:
> > +     if (0 != stat(BACKUP_LABEL_FILE, &stat_buf))
> >
> > (there's a number of similar places)
>
> I see. Lacking guidelines, I now copied how stat(2) is used in
> other parts of the code.

Really? I thought we didn't do that :), and I recall having my own
patches bounced for the same reason.

Just to be sure, we are talking about the
if (0 == foo)
vs
if (foo == 0)

thing, right? If not, then I wasn't clear enough in my note :-(

//Magnus

В списке pgsql-patches по дате отправления:

Предыдущее
От: "Albe Laurenz"
Дата:
Сообщение: Re: Improve shutdown during online backup, take 3
Следующее
От: H.Harada
Дата:
Сообщение: temporal version of generate_series()