Re: Patch: create or replace language

Поиск
Список
Период
Сортировка
От Alvaro Herrera
Тема Re: Patch: create or replace language
Дата
Msg-id 20091006142450.GE5929@alvh.no-ip.org
обсуждение исходный текст
Ответ на Patch: create or replace language  (Andreas 'ads' Scherbaum <adsmail@wars-nicht.de>)
Ответы Re: Patch: create or replace language  (Robert Haas <robertmhaas@gmail.com>)
Список pgsql-hackers
Andreas 'ads' Scherbaum wrote:
> 
> Hello,
> 
> following this old discussion:
> 
> http://archives.postgresql.org/pgsql-patches/2008-03/msg00402.php
> 
> i modifies the patch to use the "CREATE [OR REPLACE] LANGUAGE" syntax.
> If the patch is ok, i will add the documentation too.

Please send a context diff (however much ED IS THE STANDARD!!! TEXT
EDITOR, we don't like its patches here).  Note that you probably missed
updates to other functions touching the node to which you add the
boolean.  Also, per Tom's followup,

> Index: src/include/nodes/parsenodes.h
> ===================================================================
> RCS file: /projects/cvsroot/pgsql/src/include/nodes/parsenodes.h,v
> retrieving revision 1.402
> diff -r1.402 parsenodes.h
> 1570a1571
> >     bool        replace;        /* T => replace if already exists */

this comment needs fixed.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: Patch: create or replace language
Следующее
От: Alvaro Herrera
Дата:
Сообщение: Re: [PATCH] DefaultACLs