> No, I think we left it that way on purpose. I don't remember the
> discussion exactly, but I don't think it's hurting anything.
This was a part of original dynahash optimization patch. Since that
patch was about performance improvement and this concrete change is
about refactoring, not performance, we agreed to discuss it later as a
separate patch.
> I don't think this actually buys us anything.
For sure it doesn't make anything worse. Current code is just
confusing. I spent quite some time trying to figure out what is a
reason for passing two arguments before I realized - there is none.
--
Best regards,
Aleksander Alekseev
http://eax.me/