On Thu, Jan 12, 2017 at 10:17:52AM -0500, Tom Lane wrote:
> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> > In 9.5, the default pg_ctl stop mode was changed from "smart" to "fast".
> > In pg_upgrade, there is this code:
> > ...
> > I think the last line should be changed to something like
> > fast ? "-m fast" : "-m smart");
>
> Ugh. Clear oversight.
>
> There is maybe room for a separate discussion about whether pg_upgrade
> *should* be using fast mode, but if so we could remove the "bool fast"
> argument from this function altogether.
Agreed, it should be remove. Should I do it?
-- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB
http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +