Re: [PATCH] Do not use StdRdOptions in Access Methods

On Wed, Nov 13, 2019 at 04:26:53PM +0300, Nikolay Shaplov wrote:
> I've changed the patch to use build_reloptions function and again propose it
> to the commitfest.

Thanks for the new patch.  I have not reviewed the patch in details,
but I have a small comment.

> +#define SpGistGetFillFactor(relation) \
> +    ((relation)->rd_options ? \
> +        ((SpGistOptions *) (relation)->rd_options)->fillfactor : \
> +        SPGIST_DEFAULT_FILLFACTOR)
> +
Wouldn't it make sense to add assertions here to make sure that the
relkind is an index?  You basically did that in commit 3967737.
--
Michael