Re: pgbench - use pg logging capabilities

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: pgbench - use pg logging capabilities
Дата
Msg-id 20200110040844.GG1702@paquier.xyz
обсуждение исходный текст
Ответ на Re: pgbench - use pg logging capabilities  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: pgbench - use pg logging capabilities  (Fabien COELHO <coelho@cri.ensmp.fr>)
Список pgsql-hackers
On Thu, Jan 09, 2020 at 08:09:29PM -0500, Tom Lane wrote:
> TBH, my recommendation would be to drop *all* of these likely()
> and unlikely() calls.  What evidence have you got that those are
> meaningfully improving the quality of the generated code?  And if
> they're buried inside macros, they certainly aren't doing anything
> useful in terms of documenting the code.

Yes.  I am wondering if we should not rework this part of the logging
with something like the attached.  My 2c, thoughts welcome.
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Amit Kapila
Дата:
Сообщение: Re: logical decoding : exceeded maxAllocatedDescs for .spill files
Следующее
От: Dilip Kumar
Дата:
Сообщение: Re: PATCH: logical_work_mem and logical streaming of largein-progress transactions