Re: Print physical file path when checksum check fails

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: Print physical file path when checksum check fails
Дата
Msg-id 20200219042804.GD2288@paquier.xyz
обсуждение исходный текст
Ответ на Re: Print physical file path when checksum check fails  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Ответы Re: Print physical file path when checksum check fails  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Список pgsql-hackers
On Wed, Feb 19, 2020 at 01:07:36PM +0900, Kyotaro Horiguchi wrote:
> If we also verify checksum in md layer, callback is overkill since the
> immediate caller consumes the event immediately.  We can signal the
> error by somehow returning a file tag.

FWIW, I am wondering if there is any need for a change here and
complicate more the code.  If you know the block number, the page size
and the segment file size you can immediately guess where is the
damaged block.  The first information is already part of the error
message, and the two other ones are constants defined at
compile-time.
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Amit Kapila
Дата:
Сообщение: Re: Parallel copy
Следующее
От: Tom Lane
Дата:
Сообщение: Re: Resolving the python 2 -> python 3 mess