On 2020-Jun-16, Justin Pryzby wrote:
> On Tue, Jun 16, 2020 at 08:09:26PM -0400, Alvaro Herrera wrote:
Thanks for the review. I merged all your suggestions. This one:
> > Most local objects belong to a specific
> > + <glossterm linkend="glossary-schema">schema</glossterm> in their
> > + containing database, such as
> > + <glossterm linkend="glossary-relation">all types of relations</glossterm>,
> > + <glossterm linkend="glossary-function">all types of functions</glossterm>,
>
> Maybe say: >Relations< (all types), and >Functions< (all types)
led me down not one but two rabbit holes; first I realized that
"functions" is an insufficient term since procedures should also be
included but weren't, so I had to add the more generic term "routine"
and then modify the definitions of all routine types to mix in well. I
think overall the quality of these definitions is improved as a result.
I also felt the need to revise the definition of "relations", so I did
that too; this made me change the definition of resultset too.
On 2020-Jun-17, Jürgen Purtz wrote:
> +1, with two formal changes:
>
> - Rearrangement of term "Data page" to meet alphabetical order.
To forestall these ordering issues (look, another rabbit hole), I
grepped the file for all glossterms and sorted that under en_US rules,
then reordered the terms to match that. Turns out there were several
other ordering mistakes.
git grep '<glossterm>' | sed -e 's/<[^>]*>\([^<]*\)<[^>]*>/\1/' > orig
LC_COLLATE=en_US.UTF-8 sort orig > sorted
(Eliminating the tags is important, otherwise the sort uses the tags
themselves to disambiguate)
> One last question: The definition of "Data directory" reads "... A cluster's
> storage space comprises the data directory plus ..." and 'cluster' links to
> '"glossary-instance". Shouldn't it link to "glossary-db-cluster"?
Yes, an oversight, thanks.
I also added TPS, because I had already written it.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services