Re: min_safe_lsn column in pg_replication_slots view

Поиск
Список
Период
Сортировка
От Alvaro Herrera
Тема Re: min_safe_lsn column in pg_replication_slots view
Дата
Msg-id 20200708230757.GA28114@alvherre.pgsql
обсуждение исходный текст
Ответ на Re: min_safe_lsn column in pg_replication_slots view  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: min_safe_lsn column in pg_replication_slots view
Список pgsql-hackers
On 2020-Jul-08, Tom Lane wrote:

> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> > In absence of other suggestions I gave this the name XLogMBVarToSegs,
> > and redefined ConvertToXSegs to use that.  Didn't touch callers in
> > xlog.c to avoid pointless churn.  Pushed to both master and 13.
> 
> The buildfarm's sparc64 members seem unhappy with this.

Hmm.  Some of them are, yeah, but it's not universal.  For example
mussurana and ibisbill are not showing failures.

Anyway the error is pretty strange: only GetWALAvailability is showing a
problem, but the size calculation in the view function def is returning
a negative number, as expected.

So looking at the code in GetWALAvailability, what happens is that
targetSeg >= oldestSlotSeg, but we expect the opposite.  I'd bet for
targetSeg to be correct, since its input is just the slot LSN -- pretty
easy.  But for oldestSlotSeg, we have KeepLogSeg involved.

No immediate ideas ...

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Peter Geoghegan
Дата:
Сообщение: Re: Index Skip Scan (new UniqueKeys)
Следующее
От: Andrew Dunstan
Дата:
Сообщение: Re: Is this a bug in pg_current_logfile() on Windows?