On Sun, May 31, 2020 at 10:13:39PM +0000, Bossart, Nathan wrote:
> Here is a rebased version of the patch.
Should bin/vacuumdb support this?
Should vacuumdb have a way to pass an arbitrary option to the server, instead
of tacking on options (which are frequently forgotten on the initial commit to
the backend VACUUM command) ? That has the advantage that vacuumdb could use
new options even when connecting to a new server version than client. I think
it would be safe as long as it avoided characters like ')' and ';'. Maybe
all that's needed is isdigit() || isalpha() || isspace() || c=='_'
+ MAIN_RELATION_CLEANUP [ <replaceable class="parameter">boolean</replaceable> ]
+ TOAST_TABLE_CLEANUP [ <replaceable class="parameter">boolean</replaceable> ]
Maybe should be called TOAST_RELATION_CLEANUP
See attached.
--
Justin