Greetings,
* Michael Paquier (michael@paquier.xyz) wrote:
> On Sat, Mar 20, 2021 at 05:37:47PM +0900, Michael Paquier wrote:
> > It seems to me that this would make the tests faster, that the test
> > would not need to wait for the logging collector and that the code
> > could just use slurp_file($node->logfile) to get the data it wants to
> > check for a given pattern without looking at current_logfiles. I also
> > think that not using truncate() on the logfile generated has the
> > disadvantage to make the code fuzzy for its verification once we
> > introduce patterns close to each other, as there could easily be an
> > overlap. That's one problem that SQL pattern checks had to deal with
> > in the past. Thoughts?
>
> And, in terms of code, this really simplifies things. Please see the
> attached that I would like to apply.
Agreed, that does look better/simpler.
Thanks!
Stephen