Re: pgsql: Fix broken cast on MSVC

Поиск
Список
Период
Сортировка
От Julien Rouhaud
Тема Re: pgsql: Fix broken cast on MSVC
Дата
Msg-id 20220830022636.qrcbcecmhztbxrwa@jrouhaud
обсуждение исходный текст
Ответ на pgsql: Fix broken cast on MSVC  (John Naylor <john.naylor@postgresql.org>)
Ответы Re: pgsql: Fix broken cast on MSVC  (John Naylor <john.naylor@enterprisedb.com>)
Список pgsql-committers
Дерево обсуждения 
Hi,

On Mon, Aug 29, 2022 at 10:45:43AM +0000, John Naylor wrote:
>
> +/*
> + * Exactly like vector32_is_highbit_set except for the input type, so it
> + * looks at each byte separately.
> + *
> + * [...]
> + */
> +#ifndef USE_NO_SIMD
> +static inline bool
> +vector32_is_highbit_set(const Vector32 v)
> [...]

Shouldn't the comment be "Exactly like vector8_is_highbit_set..."?

Also, is there any reason to not have a function prototype for this one?  As
far as I can see that's the only one that doesn't in simd.h.

В списке pgsql-committers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: pgsql: Cleanup more code and comments related to Windows NT4 (XP days)
Следующее
От: David Rowley
Дата:
Сообщение: pgsql: Use MAXALIGN() in calculations using sizeof(SlabBlock)