Re: Catalog_xmin is not advanced when a logical slot is lost

Поиск
Список
Период
Сортировка
От Alvaro Herrera
Тема Re: Catalog_xmin is not advanced when a logical slot is lost
Дата
Msg-id 20221122100108.5oh2fysbrwg3r6hi@alvherre.pgsql
обсуждение исходный текст
Ответ на Re: Catalog_xmin is not advanced when a logical slot is lost  (sirisha chamarthi <sirichamarthi22@gmail.com>)
Список pgsql-hackers
On 2022-Nov-21, sirisha chamarthi wrote:

> On Mon, Nov 21, 2022 at 10:56 AM Alvaro Herrera <alvherre@alvh.no-ip.org>
> wrote:

> > Instead I'm going to do what Ashutosh mentioned at the start, which is
> > to verify both the restart_lsn and the invalidated_at, when deciding
> > whether to ignore the slot.
> 
> Sounds good to me. Thanks!

Done now.  I also a new elog(DEBUG1), which I think makes the issue a
bit easier notice.

I think it would be even better if we reset the underlying data from
effective_catalog_xmin ... even with this patch, we show a non-zero
value for a slot in status "lost" (and we ignore it when computing the
overall xmin), which I think is quite confusing.  But we can do that in
master only.

Thanks for reporting this issue.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/



В списке pgsql-hackers по дате отправления:

Предыдущее
От: gkokolatos@pm.me
Дата:
Сообщение: Re: Add LZ4 compression in pg_dump
Следующее
От: igor levshin
Дата:
Сообщение: Re: allowing for control over SET ROLE