Re: perl 5.36, C99, -Wdeclaration-after-statement -Wshadow=compatible-local

Поиск
Список
Период
Сортировка
От Andres Freund
Тема Re: perl 5.36, C99, -Wdeclaration-after-statement -Wshadow=compatible-local
Дата
Msg-id 20221229000223.2pdwxexfrgoximul@awork3.anarazel.de
обсуждение исходный текст
Ответ на Re: perl 5.36, C99, -Wdeclaration-after-statement -Wshadow=compatible-local  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: perl 5.36, C99, -Wdeclaration-after-statement -Wshadow=compatible-local  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
On 2022-12-28 13:43:27 -0500, Tom Lane wrote:
> > In the compiler test, I chose to not check whether -Werror=unknown-pragmas is
> > supported - it appears to be an old gcc flag, and the worst outcome is that
> > HAVE_PRAGMA_SYSTEM_HEADER isn't defined.
> > We could alternatively define HAVE_PRAGMA_SYSTEM_HEADER or such based on
> > __GNUC__ being defined.
> 
> Hmm ... I guess the buildfarm would tell us whether that detection works
> correctly on platforms where it matters.  Let's keep it simple if we
> can.

Quick clarification question: Are you suggesting to use #ifdef __GNUC__, or
that it suffices to use -Werror=unknown-pragmas without a separate configure
check?



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: pg_stat_bgwriter.buffers_backend is pretty meaningless (and more?)
Следующее
От: Tom Lane
Дата:
Сообщение: Re: perl 5.36, C99, -Wdeclaration-after-statement -Wshadow=compatible-local