Re: pgsql: Allow logical decoding on standbys

Поиск
Список
Период
Сортировка
От Kyotaro Horiguchi
Тема Re: pgsql: Allow logical decoding on standbys
Дата
Msg-id 20230414.163639.1769329243014370943.horikyota.ntt@gmail.com
обсуждение исходный текст
Ответ на Re: pgsql: Allow logical decoding on standbys  (Robert Haas <robertmhaas@gmail.com>)
Список pgsql-committers
At Thu, 13 Apr 2023 12:07:19 -0400, Robert Haas <robertmhaas@gmail.com> wrote in 
> On Wed, Apr 12, 2023 at 1:43=E2=80=AFPM Andres Freund <andres@anarazel.de> =
> wrote:
> > > And, a nearby commit addds the following message.
> > >
> > > +                     appendStringInfo(&err_detail, _("Logical decoding=
>  on standby requires wal_level to be at least logical on the primary server=
> "));
> > >
> > > This is omitting the indefinite article before "standby". I'm not sure
> > > what to do about it but feel like we don't need it here.
> >
> > I don't think we need it either, but I'm not a native speaker.
> 
> I am a native speaker of English and I think it is not required here.
> If we were going to add an article, I think we would want an
> indefinite one ("a standby") not a definite one ("the standby")
> because we're talking about a general truism, not a situation that
> pertains to one specific server. However, I don't think we should add
> that because the current phrasing is more consistent with our general
> practice. It's not the way you would actually talk, but it the way
> that people often write error messages. For example, we say "file not
> found" not "the file was not found," and nobody gets upset or confused
> by that.

Thaks for the clarification!

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center



В списке pgsql-committers по дате отправления:

Предыдущее
От: David Rowley
Дата:
Сообщение: pgsql: Fix incorrect partition pruning logic for boolean partitioned ta
Следующее
От: Peter Eisentraut
Дата:
Сообщение: pgsql: Add missing source files to nls.mk