On 2023-Nov-15, Michael Paquier wrote:
> On Tue, Nov 14, 2023 at 02:11:50PM +0100, Alvaro Herrera wrote:
> > You named the hash table InjectionPointHashByName, which seems weird.
> > Is there any *other* way to locate an injection point that is not by
> > name?
>
> I am not sure what you mean here. Names are kind of the most
> portable and simplest thing I could think of.
Oh, I think you're overthinking what my comment was. I was saying, just
name it "InjectionPointsHash". Since there appears to be no room for
another hash table for injection points, then there's no need to specify
that this one is the ByName hash. I couldn't think of any other way to
organize the injection points either.
> > In this patch, injection points are instance-wide (because the hash
> > table is in shmem).
>
> Yes, still not something that's required in the core APIs or an
> initial batch.
I agree that we can do the easy thing first and build it up later. I
just hope we don't get too wedded on the current interface because of
lack of time in the current release that we get stuck with it.
> I am not sure that it is a good idea to enforce a specific conditional
> logic in the backend core code.
Agreed, let's get more experience on what other types of tests people
want to build, and how are things going to interact with each other.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"No necesitamos banderas
No reconocemos fronteras" (Jorge González)