On Thu, Nov 16, 2023 at 06:06:30PM -0500, Tom Lane wrote:
> I'm generally sympathetic to the idea that simd.h was a rather large
> dependency to add to something as widely used as pg_wchar.h. So I'd
> favor getting it out of there just on compilation-time grounds,
> independently of whether it's causing active problems. That argument
> wouldn't justify a back-patch, but "it's causing problems" might.
Given the lack of evidence of anyone else using is_valid_ascii(), I'm
leaning towards back-patching being the better option in this case. I
don't know if it'll be feasible to keep simd.h out of all headers that
third-party code might want to use forever, but that's not an argument
against doing this right now for pgrx.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com