Re: Should we remove -Wdeclaration-after-statement?

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Should we remove -Wdeclaration-after-statement?
Дата
Msg-id 2053130.1706566163@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Should we remove -Wdeclaration-after-statement?  (Andres Freund <andres@anarazel.de>)
Ответы Re: Should we remove -Wdeclaration-after-statement?  (Andres Freund <andres@anarazel.de>)
Список pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> On 2024-01-29 15:01:06 -0500, Robert Haas wrote:
>> And it still baffles me why we allow everyone to pick their own system for
>> capitalizing identifiers out of a hat, without even insisting on consistency
>> from one end of the same identifier to the other.

> Yes. Please. I hate some capitalization/underscore styles, but I hate spending
> time feeling out which capitalization style I should use so much more.  Let's
> at least define some minimal naming guidelines for new code.

I'm for this for entirely-new code, but I think when adding code in
existing modules we're better off with the rule of "make it match
nearby code".  I admit it might be hard to draw a clear line between
the two cases, plus there might be local inconsistency already.
But let's try to avoid making local style inconsistencies worse.

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: David Rowley
Дата:
Сообщение: Re: Streaming read-ready sequential scan code
Следующее
От: David Rowley
Дата:
Сообщение: Re: Optmize bitmapword macros calc (src/backend/nodes/bitmapset.c)