Re: pgsql: Update obsolete index scan TID comments.

Поиск
Список
Период
Сортировка
От Alexander Lakhin
Тема Re: pgsql: Update obsolete index scan TID comments.
Дата
Msg-id 21c7267f-c27b-af5a-2c61-8777098587cb@gmail.com
обсуждение исходный текст
Ответ на pgsql: Update obsolete index scan TID comments.  (Peter Geoghegan <pg@bowt.ie>)
Список pgsql-committers
Hello Peter,

12.03.2024 01:07, Peter Geoghegan wrote:
> Update obsolete index scan TID comments.
>
> Oversight in commit c2fe139c20.

I found one more obsolete comment mentioning xs_ctup:
             /*
              * For IndexOnlyScan, the tuple stored in ss_ScanTupleSlot may be
              * a virtual tuple that does not have the ctid column, so we have
              * to get the TID from xs_ctup.t_self.
              */
             IndexScanDesc scan = ((IndexOnlyScanState *) scanstate)->ioss_ScanDesc;

             *current_tid = scan->xs_heaptid;

Maybe you would like to fix it too...

Best regards,
Alexander



В списке pgsql-committers по дате отправления:

Предыдущее
От: Peter Eisentraut
Дата:
Сообщение: pgsql: Revise GUC names quoting in messages again
Следующее
От: Peter Eisentraut
Дата:
Сообщение: pgsql: A few follow-up fixes for GUC name quoting