Re: Cause of recent buildfarm failures on hamerkop

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Cause of recent buildfarm failures on hamerkop
Дата
Msg-id 22840.1347659585@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Cause of recent buildfarm failures on hamerkop  (Magnus Hagander <magnus@hagander.net>)
Список pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes:
> On Fri, Sep 14, 2012 at 7:02 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I'm not sure if we should just write this off as pilot error, or if we
>> should try to make the regression tests proof against such things.  If
>> the latter, how exactly?

> I don't think we need to make them proof against it. But it wouldn't
> hurt to have a check that threw a predictable error when it happens.
> E.g. a first step in the regression tests that just verifies what kind
> of line endings are in a file. Could maybe be as simple as checking
> the size of the file?

Yeah, it would be easy to add a query that prints the large object's size
to the currently-failing test.  That seems like a good idea
independently of whether we add a .gitattributes file as Aidan suggests.
        regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: Identity projection
Следующее
От: Tom Lane
Дата:
Сообщение: Re: Cause of recent buildfarm failures on hamerkop