Re: BUG #17212: pg_amcheck fails on checking temporary relations

Поиск
Список
Период
Сортировка
От Mark Dilger
Тема Re: BUG #17212: pg_amcheck fails on checking temporary relations
Дата
Msg-id 2306C399-4919-4694-9A0E-72CB5EE1D0B8@enterprisedb.com
обсуждение исходный текст
Ответ на Re: BUG #17212: pg_amcheck fails on checking temporary relations  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: BUG #17212: pg_amcheck fails on checking temporary relations
Список pgsql-hackers

> On Oct 14, 2021, at 2:13 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> (a) Isn't that just holding open one connection, not the whole instance?

Yes.

> (b) Wouldn't finish()ing that connection cause the temp tables to be
> dropped, negating the entire point of the test?

The finish() would have to be the last line of the test.

> TBH, I seriously doubt this test case is worth expending buildfarm
> cycles on forevermore.  I'm more than a bit tempted to just drop
> it, rather than also expending developer time figuring out why it's
> not as portable as it looks.

I'm curious if the test is indicating something about the underlying test system.  Only one other test in the tree uses
background_psql(). I was hoping Andrew would have something to say about whether this is a bug with that function or
justuser error on my part. 

—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company






В списке pgsql-hackers по дате отправления:

Предыдущее
От: John Naylor
Дата:
Сообщение: Re: [RFC] building postgres with meson
Следующее
От: Peter Geoghegan
Дата:
Сообщение: Re: BUG #17212: pg_amcheck fails on checking temporary relations