Re: Ctid chain following enhancement

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Ctid chain following enhancement
Дата
Msg-id 23118.1169932631@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Ctid chain following enhancement  ("Pavan Deolasee" <pavan.deolasee@gmail.com>)
Ответы Re: Ctid chain following enhancement  ("Pavan Deolasee" <pavan.deolasee@gmail.com>)
Список pgsql-patches
"Pavan Deolasee" <pavan.deolasee@gmail.com> writes:
> On 1/27/07, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> It looks to me that you have introduced a buffer leak into
>> heap_get_latest_tid ...

> I can't spot that.

No, you're right, my apologies.  I was thinking that the patch ought to
introduce an UnlockReleaseBuffer after the loop, but that's not
necessary given the calls before all the breaks.  (OTOH it might be
cleaner to refactor things that way, if we were going to apply this.
I still don't think heap_get_latest_tid is worth any optimization
effort, though.)

            regards, tom lane

В списке pgsql-patches по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: minor regression test refactor
Следующее
От: Tom Lane
Дата:
Сообщение: Re: [DOCS] Change draft gmake control