Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> pgbench has one occurrence of the old pattern in master, in line 6043.
> However, since doConnect() returns NULL when it gets CONNECTION_BAD,
> that seems dead code. This patch kills it.
Oh ... I missed that because it wasn't adjacent to the PQconnectdbParams
call :-(. You're right, that's dead code and we should just delete it.
regards, tom lane