Re: [PATCH] Replace a long chain of if's in eval_const_expressions_mutator by a switch()

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: [PATCH] Replace a long chain of if's in eval_const_expressions_mutator by a switch()
Дата
Msg-id 25027.1321650862@sss.pgh.pa.us
обсуждение исходный текст
Ответ на [PATCH] Replace a long chain of if's in eval_const_expressions_mutator by a switch()  (Andres Freund <andres@anarazel.de>)
Ответы Re: [PATCH] Replace a long chain of if's in eval_const_expressions_mutator by a switch()  (Andres Freund <andres@anarazel.de>)
Список pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> For unknown reasons the function used non chained ifs for every handled
> nodeType.
> Replacing the if chain with if; else if; ... resulted in a small
> speedup. Replacing it with a switch() in a bigger one.

Cool, but this patch is impossible to validate by eye.  Could you
resubmit a version that doesn't reindent unchanged code?  Leave it
for pgindent to clean that up later.
        regards, tom lane


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: EXPLAIN (plan off, rewrite off) for benchmarking
Следующее
От: Peter Geoghegan
Дата:
Сообщение: Re: Inlining comparators as a performance optimisation