Re: PGDLLEXPORTing all GUCs?

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: PGDLLEXPORTing all GUCs?
Дата
Msg-id 25882.1399469706@sss.pgh.pa.us
обсуждение исходный текст
Ответ на PGDLLEXPORTing all GUCs?  (Craig Ringer <craig@2ndquadrant.com>)
Ответы Re: PGDLLEXPORTing all GUCs?  (Andres Freund <andres@2ndquadrant.com>)
Список pgsql-hackers
Craig Ringer <craig@2ndquadrant.com> writes:
> Is there any reason _not_ to PGDLLEXPORT all GUCs, other than cosmetic
> concerns?

That seems morally equivalent to "is there a reason not to make every
static variable global?".

IOW, no, I don't accept this proposition.  Every time we DLLEXPORT some
variable, we lose the freedom to redefine it later.  So DLLEXPORT'ing GUCs
should be on a case by case basis, just as for any other variable.  In
some cases it might be smarter to export a wrapper function.
        regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Magnus Hagander
Дата:
Сообщение: Re: Wanted: jsonb on-disk representation documentation
Следующее
От: Tom Lane
Дата:
Сообщение: Re: Wanted: jsonb on-disk representation documentation