Re: [HACKERS] Custom compression methods

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: [HACKERS] Custom compression methods
Дата
Msg-id 261449.1616267030@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: [HACKERS] Custom compression methods  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: [HACKERS] Custom compression methods  (Andrew Dunstan <andrew@dunslane.net>)
Re: [HACKERS] Custom compression methods  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
I wrote:
> Yeah, _doSetFixedOutputState is the wrong place: that runs on the
> pg_restore side of the fence, and would not have access to the
> necessary info in a separated dump/restore run.

> It might be necessary to explicitly pass the state through in a TOC item,
> as we do for things like the standard_conforming_strings setting.

Ah, now that I read your patch I see that's exactly what you did.

I fixed up some issues in 0008/0009 (mostly cosmetic, except that
you forgot a server version check in dumpToastCompression) and
pushed that, so we can see if it makes crake happy.

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Gilles Darold
Дата:
Сообщение: Re: [PATCH] proposal for regexp_count, regexp_instr, regexp_substr and regexp_replace
Следующее
От: Peter Eisentraut
Дата:
Сообщение: Re: popcount