nield@usol.com writes:
> What if BasicOpenFile() got some other error?
Doesn't really matter; anything else would be a problem we can't recover
from anyhow. Besides, given that rename is failing with ENOENT, a
conflict on the destination name does not appear to be the issue.
regards, tom lane