Re: posix_fadvise versus old kernels

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: posix_fadvise versus old kernels
Дата
Msg-id 26472.1151434272@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: posix_fadvise versus old kernels  (Bruce Momjian <bruce@momjian.us>)
Список pgsql-hackers
Bruce Momjian <bruce@momjian.us> writes:
> Tom Lane wrote:
>> While we could possibly come up with a suitable configure test to
>> determine whether posix_fadvise is actually safe to use on a given
>> system, I think we should seriously consider just reverting the patch.
>> As far as I saw, zero evidence was given that it actually does anything
>> measurable.  Without a benchmark to prove that it's worth spending more
>> time on, I'm disinclined to trouble over it.

> Agreed.  How about if we just #ifdef NOT_USED the code and mention the
> problem in a comment.

Works for me; I'll write something and commit it.  We can leave the
is-posix_fadvise-declared configure test in place, at least for now ...
        regards, tom lane


В списке pgsql-hackers по дате отправления:

Предыдущее
От: "Mark Woodward"
Дата:
Сообщение: Re: SO_SNDBUF size is small on win32?
Следующее
От: Stefan Kaltenbrunner
Дата:
Сообщение: Re: GIN index creation extremely slow ?