Re: pgsql: psql: add an optional execution-count limit to \watch.

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: pgsql: psql: add an optional execution-count limit to \watch.
Дата
Msg-id 2929174.1680876023@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: pgsql: psql: add an optional execution-count limit to \watch.  (Alexander Korotkov <aekorotkov@gmail.com>)
Ответы Re: pgsql: psql: add an optional execution-count limit to \watch.  (Alexander Korotkov <aekorotkov@gmail.com>)
Список pgsql-committers
Alexander Korotkov <aekorotkov@gmail.com> writes:
> On Thu, Apr 6, 2023 at 8:18 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> psql: add an optional execution-count limit to \watch.

> This commit makes tests fail for me.  psql parses 'i' option of
> '\watch' using locale-aware strtod(), but 001_basic.pl uses hard-coded
> decimal separator.

Huh, yeah, I see it too if I set LANG=ru_RU.utf8 before running psql's
TAP tests.  It seems unfortunate that none of the buildfarm has noticed
this.  I guess all the TAP tests are run under C locale?

> The proposed fix is attached.

LGTM, will push in a bit (unless you want to?)

            regards, tom lane



В списке pgsql-committers по дате отправления:

Предыдущее
От: Alexander Korotkov
Дата:
Сообщение: Re: pgsql: psql: add an optional execution-count limit to \watch.
Следующее
От: Alexander Korotkov
Дата:
Сообщение: Re: pgsql: psql: add an optional execution-count limit to \watch.