Re: Re: pgsql: Cosmetic improvements in plpython's make rule for libpython impo

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Re: pgsql: Cosmetic improvements in plpython's make rule for libpython impo
Дата
Msg-id 29542.1408290909@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: pgsql: Cosmetic improvements in plpython's make rule for libpython impo  (Noah Misch <noah@leadboat.com>)
Ответы Re: Re: pgsql: Cosmetic improvements in plpython's make rule for libpython impo  (Noah Misch <noah@leadboat.com>)
Список pgsql-committers
Noah Misch <noah@leadboat.com> writes:
> On Fri, Feb 14, 2014 at 04:31:42PM +0000, Tom Lane wrote:
>> Cosmetic improvements in plpython's make rule for libpython import library.
>>
>> This build technique is remarkably ugly, but that doesn't mean it has
>> to be unreadable too.  Be a bit more liberal with the vertical whitespace,
>> and give the .def file a proper dependency, just in case.

> That dependency omission was no accident.  See commit 0d147e43 and
> contemporary discussion.

Hm.  I failed to find the "contemporary discussion" after a bit of
looking, but surely there's a way to get Cygwin's make to handle file
names with colons in them?  Or if not, maybe we should try to strip out
any drive letter appearing in the DLL spec?  I do not really believe the
argument that we don't need a dependency there.

            regards, tom lane


В списке pgsql-committers по дате отправления:

Предыдущее
От: Peter Eisentraut
Дата:
Сообщение: pgsql: doc: Work around stylesheet bug for man build
Следующее
От: Noah Misch
Дата:
Сообщение: Re: Re: pgsql: Cosmetic improvements in plpython's make rule for libpython impo