Re: pgsql: Further dtrace adjustments for the backend-IDs-in-relpath patch.

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: pgsql: Further dtrace adjustments for the backend-IDs-in-relpath patch.
Дата
Msg-id 29973.1281803715@sss.pgh.pa.us
обсуждение исходный текст
Ответ на pgsql: Further dtrace adjustments for the backend-IDs-in-relpath patch.  (rhaas@postgresql.org (Robert Haas))
Ответы Re: pgsql: Further dtrace adjustments for the backend-IDs-in-relpath patch.  (Robert Haas <robertmhaas@gmail.com>)
Список pgsql-committers
rhaas@postgresql.org (Robert Haas) writes:
> Further dtrace adjustments for the backend-IDs-in-relpath patch.

Hrm, this doesn't look right at all.  The documentation now advertises
that backendid is passed to a number of probes that the code isn't
actually doing that for.  I agree with the changes proposed by the
docs changes, and would suggest that buffer-flush-start,
buffer-flush-done, buffer-write-dirty-start, and buffer-write-dirty-done
probes probably need to get the backendid too.  But in any case the
code isn't matching the docs in HEAD.

            regards, tom lane

В списке pgsql-committers по дате отправления:

Предыдущее
От: tgl@postgresql.org (Tom Lane)
Дата:
Сообщение: pgsql: Fix planner to make a reasonable assumption about the amount of
Следующее
От: Robert Haas
Дата:
Сообщение: Re: pgsql: Further dtrace adjustments for the backend-IDs-in-relpath patch.