> On 25 Mar 2020, at 15:35, Pengzhou Tang <ptang@pivotal.io> wrote:
> Thanks a lot, the patch has a memory leak in the lookup_hash_entries, it uses a list_concat there
> and causes a 64-byte leak for every tuple, has fixed that.
>
> Also, resolved conflicts and rebased the code.
While there hasn't been a review of this version, it no longer applies to HEAD.
There was also considerable discussion in a (virtual) hallway-track session
during PGCon which reviewed the approach (for lack of a better description),
deeming that nodeAgg.c needs a refactoring before complicating it further.
Based on that, and an off-list discussion with Melanie who had picked up the
patch, I'm marking this Returned with Feedback.
cheers ./daniel