> On 7 Feb 2022, at 17:29, Andrew Dunstan <andrew@dunslane.net> wrote:
> On 2/2/22 14:50, Daniel Gustafsson wrote:
>>> On 2 Feb 2022, at 17:09, Andrew Dunstan <andrew@dunslane.net> wrote:
>>> On 2/2/22 08:26, Daniel Gustafsson wrote:
>>>> Thoughts? I'm fairly sure there are many crimes against Perl in this patch,
>>>> I'm happy to take pointers on how to improve that.
>>> It feels a bit odd to me from a perl POV. I think it needs to more along
>>> the lines of standard OO patterns. I'll take a stab at that based on
>>> this, might be a few days.
>> That would be great, thanks!
>
> Here's the result of that surgery. It's a little incomplete in that it
> needs some POD adjustment, but I think the code is right - it passes
> testing for me.
Confirmed, it passes all tests for me as well.
> One of the advantages of this, apart from being more idiomatic, is that
> by avoiding the use of package level variables you can have two
> SSL::Server objects, one for OpenSSL and (eventually) one for NSS. This
> was the original motivation for the recent install_path additions to
> PostgreSQL::Test::Cluster, so it complements that work nicely.
Agreed, this version is a clear improvement over my attempt. Thanks!
The attached v2 takes a stab at fixing up the POD sections.
--
Daniel Gustafsson https://vmware.com/