Hi,
On 4/2/23 5:42 AM, Andres Freund wrote:
> Hi,
>
> On 2023-03-31 12:45:51 +0200, Drouvot, Bertrand wrote:
>
> I pushed a commit just adding an assertion that only valid bits are passed in.
>
>
Thanks!
>>> I'm also thinking of splitting the patch into two. One patch to pass down the
>>> heap relation into the new places, and another for the rest.
>>
>> I think that makes sense. I don't know how far you've work on the split but please
>> find attached V54 doing such a split + implementing your VISIBILITYMAP_XLOG_VALID_BITS
>> suggestion.
>
> I pushed the pass-the-relation part.
Thanks! I just created a new thread [1] for passing down the heap relation to GlobalVisTestFor() in
vacuumRedirectAndPlaceholder().
> I removed an include of catalog.h that
> was in the patch - I suspect it might have slipped in there from a later patch
> in the series...
>
Oops, my bad. Thanks! Yeah, indeed it's due to the split and it's in fact needed in
"Add-info-in-WAL-records-in-preparation-for-logic.patch".
Please find enclosed v55 with the correction (re-adding it Add-info-in-WAL-records-in-preparation-for-logic.patch as
compareto v54).
> I was a bit bothered by using 'heap' instead of 'table' in so many places
> (eventually we imo should standardize on the latter), but looking around the
> changed places, heap was used for things like buffers etc.
yup
[1]: https://www.postgresql.org/message-id/flat/02392033-f030-a3c8-c7d0-5c27eb529fec%40gmail.com
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com