Hi Ashutosh,
On 2017/03/23 21:48, Ashutosh Bapat wrote:
>>> I have fixed all the issues reported till now.
In patch 0007, the following code in have_partkey_equi_join() looks
potentially unsafe:
/* * If the clause refers to different partition keys from * both relations, it can not be used
forpartition-wise join. */ if (ipk1 != ipk2) continue;
/* * The clause allows partition-wise join if only it uses the same * operator family as that
specifiedby the partition key. */ if (!list_member_oid(rinfo->mergeopfamilies,
part_scheme->partopfamily[ipk1])) continue;
What if ipk1 and ipk2 both turn out to be -1? Accessing
part_schem->partopfamily[ipk1] would be incorrect, no?
Thanks,
Amit