Re: configure's checks for --enable-tap-tests are insufficient

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: configure's checks for --enable-tap-tests are insufficient
Дата
Msg-id 30398.1521564644@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: configure's checks for --enable-tap-tests are insufficient  (ilmari@ilmari.org (Dagfinn Ilmari Mannsåker))
Ответы Re: configure's checks for --enable-tap-tests are insufficient  (ilmari@ilmari.org (Dagfinn Ilmari Mannsåker))
Список pgsql-hackers
ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes:
> Tom Lane <tgl@sss.pgh.pa.us> writes:
>> ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes:
>>> I think the other way would be better simpler: we require a complete
>>> Perl core installation.

>> And you propose to test for that in configure how?

> Good point, I'd overlooked that aspect.  In that case we can't rely on
> what Debian or others happen to include in their minimal packages, we
> have to explicitly check for _every_ module we use anywhere in the test
> suite, core or not (except perhaps pragmas like 'strict' and 'warnings').

That seems like expensive overkill to me, especially since it seems
unlikely that we'd keep the list up-to-date over time.  I just want to
test for modules that we know are likely to be omitted on popular
platforms.  I've proposed testing two that would improve the user
experience on Red Hat; what's the equivalent minimum set for Debian?

I think the documentation can reasonably say that we expect perl-core
(plus IPC::Run, if that's not core).  But configure's task is just to
make a reasonable attempt to notice if you're missing something.  If
we have to tweak it again in the future, that's fine with me.

            regards, tom lane


В списке pgsql-hackers по дате отправления:

Предыдущее
От: ilmari@ilmari.org (Dagfinn Ilmari Mannsåker)
Дата:
Сообщение: Re: configure's checks for --enable-tap-tests are insufficient
Следующее
От: Garima Natani
Дата:
Сообщение: GSOC 2018 Proposal review