Heikki Linnakangas <hlinnakangas@vmware.com> wrote:
> On 02/04/2015 04:49 PM, Kevin Grittner wrote:
>> Would anyone object to me removing the first parameter
>> (including, obviously, in all references in our code tree)?
>
> No objection, although I have to wonder why bother?
Because I ran across it while trying to work on something and
wasted time checking to see what the heck it was doing with that
parameter. Having invested that time and confirmed that it was
useless, it seemed like it was worth cleaning up to save others the
same bother.
> While you're at it, the 'size' argument to _bt_pageinit is also
> pretty useless. It's useless for PageInit() too, but that's used
> in more places, potentially even in extensions.
Well, I wasn't out searching for problems like this. I was just
going to fix the one I happened to stubbed my toe on; but if you
feel these should be changed at the same time, I could do that.
--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company