Re: pgsql: Skip \password TAP test on old IPC::Run versions

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: pgsql: Skip \password TAP test on old IPC::Run versions
Дата
Msg-id 3618405.1680985800@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: pgsql: Skip \password TAP test on old IPC::Run versions  (Daniel Gustafsson <daniel@yesql.se>)
Ответы Re: pgsql: Skip \password TAP test on old IPC::Run versions  (Andrew Dunstan <andrew@dunslane.net>)
Список pgsql-committers
Daniel Gustafsson <daniel@yesql.se> writes:
> On 8 Apr 2023, at 18:23, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Can't we write "use IPC::Run 0.98;" and let
>> some other code manage the version comparison?

> We can, but that AFAIK (Andrew might have a better answer) requires the below
> diff which I think leaves some readability to be desired:

> -   (eval { require IO::Pty; } && eval { $IPC::Run::VERSION >= '0.98' });
> +   (eval { require IO::Pty; } && !!eval { IPC::Run->VERSION('0.98'); 1 });

Maybe I'm missing something, but I was envisioning

    eval { require IO::Pty; use IPC::Run 0.98; }

with no need to do more than check if the eval traps an error.

            regards, tom lane



В списке pgsql-committers по дате отправления:

Предыдущее
От: Daniel Gustafsson
Дата:
Сообщение: Re: pgsql: Skip \password TAP test on old IPC::Run versions
Следующее
От: Thomas Munro
Дата:
Сообщение: pgsql: Use higher wal_level for 004_io_direct.pl.