Re: functional index arg matching patch

Поиск
Список
Период
Сортировка
От Mark Hollomon
Тема Re: functional index arg matching patch
Дата
Msg-id 39A27557.93AD0B72@americasm01.nt.com
обсуждение исходный текст
Ответ на functional index arg matching patch  (Mark Hollomon <mhh@mindspring.com>)
Список pgsql-hackers
Tom Lane wrote:
> 
> "Mark Hollomon" <mhh@nortelnetworks.com> writes:
> > Tom Lane wrote:
> >> Um, thanks for working on this, but I already fixed that...
> 
> > When? A message you sent on 8-11 indicated it wasn't.
> 
> (Checks CVS) ... yesterday, actually.

Yea, I saw it when a refreshed last night.

> 
> > I'll be interested in seeing how you did it.
> 
> I just called the ambiguous-function-name-resolution code in
> parse_func.c and then checked to make sure it hadn't selected
> something the executor wasn't prepared to cope with --- ie,
> functions requiring runtime conversions of input data types.
> 
> It looked like you had copied out a bunch of the parse_func.c code,
> which is OK in the short run but the duplicated code might be
> a headache to keep in sync later on.
> 

I had thought about doing it the way you did, but didn't know the
consequences of some of the other coersions that parse_func.c
tried to do. My guess that it wasn't harmless was correct judging from
your code.

-- 

Mark Hollomon
mhh@nortelnetworks.com
ESN 451-9008 (302)454-9008


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Oleg Bartunov
Дата:
Сообщение: Re: LIKE gripes (and charset docs)
Следующее
От: Tatsuo Ishii
Дата:
Сообщение: Re: Re: lost records --- problem identified!