Re: [PATCH] Do not use StdRdOptions in Access Methods

Поиск
Список
Период
Сортировка
От Nikolay Shaplov
Тема Re: [PATCH] Do not use StdRdOptions in Access Methods
Дата
Msg-id 4127670.gFlpRb6XCm@x200m
обсуждение исходный текст
Ответы Re: [PATCH] Do not use StdRdOptions in Access Methods  (Dent John <denty@QQdd.eu>)
Список pgsql-hackers
Hi! I am starting a new thread as commitfest wants new thread for new patch.

This new thread is a follow up to an https://www.postgresql.org/message-id/
2620882.s52SJui4ql%40x200m thread, where I've been trying to get rid of 
StdRdOpions structure, and now I've splitted the patch into smaller parts.

Read the quote below, to get what this patch is about

> I've been thinking about this patch and came to a conclusion that it
> would be better to split it to even smaller parts, so they can be
> easily reviewed, one by one. May be even leaving most complex
> Heap/Toast part for later.
> 
> This is first part of this patch. Here we give each Access Method it's
> own option binary representation instead of StdRdOptions.
> 
> I think this change is obvious. Because, first, Access Methods do not
> use most of the values defined in StdRdOptions.
> 
> Second this patch make Options structure code unified for all core
> Access Methods. Before some AM used StdRdOptions, some AM used it's own
> structure, now all AM uses own structures and code is written in the
> same style, so it would be more easy to update it in future.
> 
> John Dent, would you join reviewing this part of the patch? I hope it
> will be more easy now...

And now I have a newer version of the patch, as I forgot to remove 
vacuum_cleanup_index_scale_factor from StdRdOptions as it was used only in 
Btree index and now do not used at all. New version fixes it.

-- 
Software Developer: https://www.upwork.com/freelancers/~014a87e140ff02c0da
Body-oriented Therapist: https://vk.com/nataraj_rebalancing  (Russian)
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Nikolay Shaplov
Дата:
Сообщение: [PATCH] use separate PartitionedRelOptions structure to store partitioned table options
Следующее
От: Nikolay Shaplov
Дата:
Сообщение: Re: [PATCH] get rid of StdRdOptions, use individual binary reloptions representation for each relation kind instead