Re:RE: BUG #18055: logical decoding core on AllocateSnapshotBuilder()

Поиск
Список
Период
Сортировка
От ocean_li_996
Тема Re:RE: BUG #18055: logical decoding core on AllocateSnapshotBuilder()
Дата
Msg-id 461dd3e6.197a.18a13dbdc8a.Coremail.ocean_li_996@163.com
обсуждение исходный текст
Ответ на RE: BUG #18055: logical decoding core on AllocateSnapshotBuilder()  ("Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>)
Список pgsql-bugs
Дерево обсуждения
Excited! Thanks for the discussion and  the fix!

The bug seems to be solved well. And usage of PG_FINALLY can make it more elegantly.  However, for the version lacking of  PG_FINALLY, should the patch be written like that:

---
/* free context, call shutdown callback */
FreeDecodingContext(ctx);

ReplicationSlotRelease();
InvalidateSystemCaches();
}
PG_CATCH();
{
+
+    /* free context, call shutdown callback */
+     if (ctx != NULL)
+             FreeDecodingContext(ctx);
+
+    ReplicationSlotRelease();

----


Best regards!



At 2023-08-18 12:21:53, "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com> wrote:

Here is a new version patch which addressed this based on PG15.

В списке pgsql-bugs по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: BUG #18060: Left joining rows using random() function in join condition doesn't work as expected.
Следующее
От: "David G. Johnston"
Дата:
Сообщение: Re: BUG #18061: The psql -v variable option does not work for the -c command option