On 2021/03/17 12:02, Thomas Munro wrote:
> On Tue, Mar 16, 2021 at 9:10 PM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>> Thanks for the patch!
>>
>> + When set to <literal>fsync</literal>, which is the default,
>> + <productname>PostgreSQL</productname> will recursively open and fsync
>> + all files in the data directory before crash recovery begins.
>>
>> Isn't this a bit misleading? This may cause users to misunderstand that
>> such fsync can happen only in the case of crash recovery.
>
> If I insert the following extra sentence after that one, is it better?
> "This applies whenever starting a database cluster that did not shut
> down cleanly, including copies created with pg_basebackup."
Yes. Thanks!
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION