Re: Bug: PgAdmin not displaying typmod column types correctly in create or display

Поиск
Список
Период
Сортировка
От Guillaume Lelarge
Тема Re: Bug: PgAdmin not displaying typmod column types correctly in create or display
Дата
Msg-id 4B4521B8.1000101@lelarge.info
обсуждение исходный текст
Ответ на Re: Bug: PgAdmin not displaying typmod column types correctly in create or display  (Dave Page <dpage@pgadmin.org>)
Список pgadmin-support
Le 06/01/2010 19:50, Dave Page a écrit :
> On Wed, Jan 6, 2010 at 6:45 PM, Guillaume Lelarge
> <guillaume@lelarge.info> wrote:
>> The easy way to fix this is calling format_type in the query and giving
>> it the atttypmod column of pg_attribute. I can't find if there are
>> corner cases if I do this. Dave, do you know why there is a pgDatatype?
>> it seems redundant with format_type. And the latter seems to work well
>> whereas pgDatatype is surely wrong.
>
> iirc, it was intended as a type formatting and caching mechanism, that
> can not only format individual types, but can be used to populate
> combo boxes and the like with sets of types/domains with minimal
> overhead. For example, some of the dialogues can have quite a few
> combos full of types on them, which are not always the same, and not
> necessarily cheap to populate.
>

OK. I checked every call to format_type and I think only one need to be
modified. Here is a patch that fixes the issue. I'm not quite sure it
doesn't create new ones.


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

Вложения

В списке pgadmin-support по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: Re: Bug: PgAdmin not displaying typmod column types correctly in create or display
Следующее
От: Sebastian P. Luque
Дата:
Сообщение: Re: running pgagent